Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance call notification #4159

Closed
7 tasks
tobiasKaminsky opened this issue Jan 10, 2022 · 14 comments · Fixed by #4426
Closed
7 tasks

Enhance call notification #4159

tobiasKaminsky opened this issue Jan 10, 2022 · 14 comments · Fixed by #4426
Assignees
Labels
enhancement enhancement of a already implemented feature/code

Comments

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Jan 10, 2022

  • add "answer" / "decline" button to call notification, which opens browser and joins call
    • does this need talk help?
  • can response time be quicker? Not wait 30s
  • native integration or generic tray notification by us
    • later we want to add predefined replies, so we need more than "accept" / "decline" button, so please check if this would be possible with native integrations
    • mac os
      image
    • Windows
      image
    • Linux?
@tobiasKaminsky tobiasKaminsky added the enhancement enhancement of a already implemented feature/code label Jan 10, 2022
@claell claell added the design label Jan 18, 2022
@nickvergessen
Copy link
Member

can response time be quicker? Not wait 30s

Notify_push already should do it?

@tobiasKaminsky
Copy link
Member Author

  • which opens browser and joins call

@nickvergessen is this possible to directly join?

@tobiasKaminsky
Copy link
Member Author

For second step: add quick reply

@nickvergessen
Copy link
Member

nickvergessen commented Mar 17, 2022

  • which opens browser and joins call

@nickvergessen is this possible to directly join?

No, not at the moment

@tobiasKaminsky
Copy link
Member Author

  • which opens browser and joins call

@nickvergessen is this possible to directly join?

No, not at the moment

Ok, then this is out of scope right now.
Once it is possible from Talk side, we will add it as a new issue to implement it.

@tobiasKaminsky
Copy link
Member Author

@camilasan
Can you check what is better (UX, but also time wise): native integration or generic tray notification by us?

Later we want to add predefined replies, so we need more than "accept" / "decline" button, so please check if this would be possible with native integrations.

@camilasan
Copy link
Member

@jancborchardt @tobiasKaminsky I think it will be easier and quicker to do the generic tray notification.
I think we can make it look the same in the 3 platforms as the one for Windows (the screenshot in the issue description).

@tobiasKaminsky
Copy link
Member Author

Using our own notification would also make sure that we can add custom replies later 👍

@jancborchardt
Copy link
Member

jancborchardt commented Apr 11, 2022

Mockup here too, as talked about in the call :)
Incoming call

Details:

  • Text and buttons should use the default OS font size
  • Location:
    • Top right in macOS and Linux
    • Bottom right in Windows
  • With some whitespace from menu bar and right screen edge (same amount of space in both directions).
  • And rounded corners, just like the tray menu.

@tobiasKaminsky
Copy link
Member Author

  • Top right in macOS and Linux

For KDE this is totally unusually. Or at least for most users where tray bar is on bottom.
To have it more flexible (and if it is possible), shouldn't it be on right side on bottom/top, depending where the tray bar is?

@claucambra
Copy link
Collaborator

We have existing code for positioning the tray near the OS task/menu bar, IMO we should just position in same place

@jancborchardt
Copy link
Member

We have existing code for positioning the tray near the OS task/menu bar, IMO we should just position in same place

Sure, that works. :) My info was that we can only position it near the mouse cursor. But positioning it near the menu bar (or where the icon is) is better.


Also @claucambra, we were talking about possibly having a blurred version of the avatar in the background (like we do in the web, and like Teams does in the screenshot above, and others on mobile) – this could possibly look like this:
image
(Gaussian blur size 50px, and brightness decrease so the text is legible.)
But if it’s easier to do native notifications e.g. on macOS, then that would be even better.

cc @karlitschek

@karlitschek
Copy link
Member

looks awesome

@claucambra claucambra self-assigned this Apr 21, 2022
@claucambra
Copy link
Collaborator

Current implementation in PR #4426

@jancborchardt jancborchardt linked a pull request Apr 21, 2022 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement of a already implemented feature/code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants