Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when upgrading, nextcloud windows client crashes file explorer to avoid reboot, then asks for reboot anyways #4305

Closed
ThatCoffeeGuy opened this issue Feb 19, 2022 · 17 comments
Labels

Comments

@ThatCoffeeGuy
Copy link

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Expected behaviour

It should be able to upgrade without wanting to reboot if I select the option that states the same. Or at least after crashing explorer.exe, restart it.

Actual behaviour

It closes nextcloud, crashes file explorer and then demands a reboot anyways, without bringing file explorer or the taskbar back. I have to manually relaunch explorer.exe from task manager.

Steps to reproduce

  1. Download the newest available Nextcloud client, while there's another one already configured
  2. Install, go for "Close the applications and attempt to restart them"
  3. Witness explorer dying and still being asked to reboot your system

Client configuration

Client version:
Nextcloud-3.4.2-x64

Operating system: Windows 10

OS language: US ENG

Qt version used by client package (Linux only, see also Settings dialog):

Client package (From Nextcloud or distro) (Linux only):

Installation path of client:

C:\Program Files\Nextcloud

Server configuration

Nextcloud version:

Storage backend (external storage):

Logs

I have no idea how to generate logs for the installer.
Please use Gist (https://gist.github.com/) or a similar code paster for longer
logs.

  1. Client logfile:
    Since 3.1: Under the "General" settings, you can click on "Create Debug Archive ..." to pick the location of where the desktop client will export the logs and the database to a zip file.
    On previous releases: Via the command line: nextcloud --logdebug --logwindow or nextcloud --logdebug --logfile log.txt
    (See also https://docs.nextcloud.com/desktop/3.0/troubleshooting.html#log-files)

  2. Web server error log:

  3. Server logfile: nextcloud log (data/nextcloud.log):

Pictures:

nice

image

@eibex
Copy link

eibex commented Mar 7, 2022

Even if the program is not currently using VFS, and therefore doesn't require to restart Windows Explorer (and doesn't ask to restart it), after restarting the Nextcloud process the pop-up appears.

I clicked "No" and checked the program for the current version, and it was indeed running the updated one, making the reboot unnecessary.

@allexzander
Copy link
Contributor

We've got a corresponding ticket already #3551. It's not that easy. The issue is not happening on Windows 11, only on Windows 10.

@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This bug report did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

@github-actions github-actions bot added the stale label Apr 7, 2022
@ThatCoffeeGuy
Copy link
Author

The fix still isn't implemented.

@Pwuts
Copy link

Pwuts commented Apr 7, 2022

We've got a corresponding ticket already #3551. It's not that easy. The issue is not happening on Windows 11, only on Windows 10.

This is not true, I got this behavior on Windows 11 today with the 3.4.4 installer.

@github-actions github-actions bot removed the stale label Apr 7, 2022
@github-actions
Copy link

github-actions bot commented May 5, 2022

This bug report did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

@github-actions github-actions bot added the stale label May 5, 2022
@eibex
Copy link

eibex commented May 5, 2022

still relevant

@ThatCoffeeGuy
Copy link
Author

ThatCoffeeGuy commented May 13, 2022

Today it installed a new version - this time it rebooted my machine without even asking for permission. It said that it "might be needed to reboot" or something like this, but never explicitly said it is needed to be rebooted with a yes or no option (like in the past).

#4377 (comment)

Seems I am not the only one.

@github-actions
Copy link

This bug report did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

@github-actions github-actions bot added the stale label Jun 13, 2022
@ThatCoffeeGuy
Copy link
Author

Still not fixed.

@github-actions github-actions bot removed the stale label Jun 14, 2022
@cs-tum
Copy link

cs-tum commented Jul 5, 2022

I can confirm the unsolicited reboot without any prompt while updating to Desktop Client Version 3.5.2 on Windows 10.0.19044.1766.

@eibex
Copy link

eibex commented Jul 5, 2022

This is already tracked at #3551

@claucambra
Copy link
Collaborator

This issue has now been fixed in #4566 . Updates for new versions of the client post-3.5.2 should no longer force reboots. I will now close the issue. Thanks all for reporting!

@ristein
Copy link

ristein commented Aug 8, 2022

I recently updated to 3.5.4 and observed the exact behavior OP mentioned.

  1. Nextcloud Client asks for update and mentions restart necessary
  2. Taskbar vanishes and Background gets black
  3. Windows is rebooting

@claucambra
Copy link
Collaborator

I recently updated to 3.5.4 and observed the exact behavior OP mentioned.

  1. Nextcloud Client asks for update and mentions restart necessary
  2. Taskbar vanishes and Background gets black
  3. Windows is rebooting

3.5.4 was explicitly released to fix this issue -- this means the reboots should stop happening on updates beyond 3.5.4

@SaiyaDev
Copy link

I'm on version 3.6.1 after upgrading today and I had the same issue as the OP after upgrading to the newer version.

@eibex
Copy link

eibex commented Oct 20, 2022

Did you upgrade from 3.6.0 or an older version? 3.6.0 should be fixed.

It asked me to restart but I just pressed No and explorer wasn't crashed (and NC worked just fine even without restarting).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants