Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI enhancements: activities list #4433

Closed
3 tasks done
camilasan opened this issue Apr 13, 2022 · 8 comments
Closed
3 tasks done

UI enhancements: activities list #4433

camilasan opened this issue Apr 13, 2022 · 8 comments
Assignees
Labels
enhancement enhancement of a already implemented feature/code

Comments

@camilasan
Copy link
Member

camilasan commented Apr 13, 2022

Bold is for issues to focus on

  • If there are multiple entries with exactly the same wording then show only the most recent one (they are displayed multiple times even though the have the same message, like "Synced readme.md")
  • Fetching activity only on open: Show an entry below "All synced" with icon MDI sync icon and text "Loading more activity"
  • Clicking on any openable file should open the file itself in the default application and not the file viewer
@camilasan camilasan added enhancement enhancement of a already implemented feature/code feature: ⚡ activity and 🔔 notification labels Apr 13, 2022
@camilasan camilasan changed the title Enhancement: activities list UI enhancements: activities list Apr 13, 2022
@claucambra
Copy link
Collaborator

Regarding point 3 -- how do we handle activity entries that contain several files? I'm guessing a drop-down of some sort?

@camilasan
Copy link
Member Author

Regarding point 3 -- how do we handle activity entries that contain several files? I'm guessing a drop-down of some sort?

@jancborchardt @nimishavijay ^^

@claucambra
Copy link
Collaborator

Ping? @jancborchardt @nimishavijay

@nimishavijay
Copy link
Member

how do we handle activity entries that contain several files? I'm guessing a drop-down of some sort?

Sounds good to me :) we could have an expand-more icon on the right, and when clicked it shows upto 5 entries with a "Show more" button, clicking on which would show 5 more and a "Show more", etc.

What do you think? cc @jancborchardt

@jancborchardt
Copy link
Member

So activity entries should only group files which are in the same folder. And then, when one clicks on a grouped activity entry, we can open the containing folder.

What do you think?

@claucambra
Copy link
Collaborator

claucambra commented Jul 15, 2022

If there are multiple entries with exactly the same wording then show only the most recent one (they are displayed multiple times even though the have the same message, like "Synced readme.md")

#4736 should ensure that the client does not show duplicate activities, but this does not strictly resolve the behaviour your describe here as the server often provides multiple activities describing the same action at different points of time.

See for instance in this screenshot (same activity, i.e. the same file being changed by the same person, in red) from the activities app on the web interface:

Screenshot 2022-07-15 at 19 36 15

Since these are strictly separate activities served by the server I don't think we should be manually checking and filtering activities with repeated activities out @jancborchardt I would say this is behaviour that needs to be changed on the server side

@claucambra
Copy link
Collaborator

Another comment: AFAIK point number 2 is already the case, unless I am misinterpreting

@claucambra
Copy link
Collaborator

We can consider this completed :)

@tobiasKaminsky tobiasKaminsky moved this to 🧭 Planning evaluation (dont pick) in 🤖 🍏 Clients team Aug 18, 2022
@tobiasKaminsky tobiasKaminsky moved this from 🧭 Planning evaluation (dont pick) to ☑️ Done in 🤖 🍏 Clients team Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement of a already implemented feature/code
Projects
Archived in project
Development

No branches or pull requests

4 participants