Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to QT6 #4461

Closed
tobiasKaminsky opened this issue Apr 27, 2022 · 5 comments · Fixed by #4584
Closed

Upgrade to QT6 #4461

tobiasKaminsky opened this issue Apr 27, 2022 · 5 comments · Fixed by #4584
Assignees
Labels
enhancement enhancement of a already implemented feature/code

Comments

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Apr 27, 2022

Upgrading underlying QT part to latest version 6.

Might fix

Ticket for upgrading client updater server is:
https://github.com/nextcloud-gmbh/customer-client_updater_server/issues/38
nextcloud/client_updater_server#129

@tobiasKaminsky tobiasKaminsky added the enhancement enhancement of a already implemented feature/code label Apr 27, 2022
@tobiasKaminsky tobiasKaminsky moved this to 🧭 Planning evaluation (dont pick) in 🤖 🍏 Clients team Aug 18, 2022
@mgallien
Copy link
Collaborator

would improve our support for newer OS and platforms notably for macOS arm64 platforms (support for the WebView needed for GSS)
would provide native looking qml UI elements for macOS and Windows (think of the share dialog or the settings dialog that should look native)

@mgallien
Copy link
Collaborator

for reference, the network status detection code changed a lot in Qt (was called bearer management see https://doc.qt.io/qt-6/network-changes-qt6.html)

@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Aug 23, 2022

@mgallien, you state that this would allow the Share Menu to appear native, yet for Windows, does that not necessitate XAML Islands calling the actual name Share menu that "https://blogs.windows.com/wp-content/uploads/prod/sites/3/2021/07/image2.png" depicts?

@mgallien
Copy link
Collaborator

mgallien commented Sep 7, 2022

@mgallien, you state that this would allow the Share Menu to appear native, yet for Windows, not that not necessitate XAML Islands calling the actual name Share menu that "https://blogs.windows.com/wp-content/uploads/prod/sites/3/2021/07/image2.png" depicts?

you misunderstood me
I am not talking about a share menu but the Nextcloud desktop client share dialog. Currently we do have a native look but we may change the underlying implementation and this improvements could be easier to do with native look when using Qt6

@tobiasKaminsky tobiasKaminsky moved this from 🧭 Planning evaluation (dont pick) to 📄 To do (~10 entries) in 🤖 🍏 Clients team Nov 3, 2022
@tobiasKaminsky tobiasKaminsky moved this from 📄 To do (max 2 entries / member) to 🏗️ In progress in 🤖 🍏 Clients team Nov 21, 2022
@tobiasKaminsky tobiasKaminsky mentioned this issue Nov 22, 2022
5 tasks
@tobiasKaminsky tobiasKaminsky moved this from 🏗️ In progress to ☑️ Done in 🤖 🍏 Clients team Dec 1, 2022
@tobiasKaminsky tobiasKaminsky moved this from ☑️ Done to 🧭 Planning evaluation (don't pick) in 🤖 🍏 Clients team Dec 6, 2023
@mgallien
Copy link
Collaborator

mgallien commented Dec 12, 2023

@tobiasKaminsky
current state
image
only 1 automated test is failing NetrcParserTest
I would guess that anything between 5 to 10 days could do it (I am trying to not be overly optimistic as usual)
current move to qt6 is basic porting and we do not really make good use of new available features (not needed to move to qt6)

@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team Dec 21, 2023
@tobiasKaminsky tobiasKaminsky moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (max 2 entries / member) in 🤖 🍏 Clients team Jan 18, 2024
@tobiasKaminsky tobiasKaminsky moved this from 📄 To do (max 2 entries / member) to 🏗️ In progress in 🤖 🍏 Clients team Mar 13, 2024
@tobiasKaminsky tobiasKaminsky self-assigned this Mar 13, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 🤖 🍏 Clients team Apr 26, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement of a already implemented feature/code
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants