Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open file for local editing should not wait till the currently-running sync completes #5110

Closed
allexzander opened this issue Oct 29, 2022 · 1 comment · Fixed by #5175
Closed
Assignees
Labels
confirmed bug approved by the team

Comments

@allexzander
Copy link
Contributor

How to use GitHub

  • Please use the 👍 reaction to show that you want to have the same feature implemented.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Feature description

Right now, if we have a long sync already running, or, if we have a lot of files to sync (many data on the server) and we click the "Edit locally" link in the WebUI, we will have to wait indefinitely until the sync completes before the file will get opened locally or even worse it may not be selected for sync and we will still have to wait till the sync completes before seeing the error message.

We need to abort the currently running sync (maybe make sure we are not aborting hydration of a file via VFS as this might bring troubles), and then, force-sync just one file that we want to edit locally or the folder it resides in. This will make opening a file for local editing faster.

NOTE: This will need some nice design decisions.

@allexzander allexzander added enhancement confirmed bug approved by the team labels Oct 29, 2022
@allexzander
Copy link
Contributor Author

@tobiasKaminsky @jancborchardt (for design decisions)

@tobiasKaminsky tobiasKaminsky moved this to 🧭 Planning evaluation (dont pick) in 🤖 🍏 Mobile clients team Nov 3, 2022
@tobiasKaminsky tobiasKaminsky moved this from 🧭 Planning evaluation (dont pick) to 📄 To do (~10 entries) in 🤖 🍏 Mobile clients team Nov 3, 2022
@allexzander allexzander moved this from 📄 To do (~10 entries) to 🏗️ In progress in 🤖 🍏 Mobile clients team Nov 4, 2022
@tobiasKaminsky tobiasKaminsky moved this from 🏗️ In progress to ☑️ Done in 🤖 🍏 Mobile clients team Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed bug approved by the team
Projects
Development

Successfully merging a pull request may close this issue.

2 participants