Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Share options for folders uses "Custom permissions" instead of "Bundled permissions" - can only edit and not upload #5615

Closed
5 of 8 tasks
avatar1024 opened this issue Apr 19, 2023 · 8 comments

Comments

@avatar1024
Copy link

avatar1024 commented Apr 19, 2023

⚠️ Before submitting, please verify the following: ⚠️

Bug description

Hello,

Since recently (not exactly sure when but definitely the case with 3.8.0), when I create a share link on a folder via the file manager context menu, I get the share option “edit” (see screenshot 1). This used to correspond to the “edit and upload” option form the Web UI, i.e. when ticked then people with that shared link could upload files into that folder.

This is no longer the case, and is now strictly “edit”, and so people with the shared link cannot upload into it (the + sin is not present). If I look up the sharing properties of this folder in the WebUI the option is indeed only “edit” and not the bundle “edit and upload” (see screenshot 2) as it used to be.

I believe this is not the intended behaviour and is a usability regression. Or at least then upload should also be available as a share option for folder from the context menu.

I've created thread about this on the forum and it was reproduced by another user: https://help.nextcloud.com/t/missing-upload-as-share-option-for-folders-can-only-edit/160371

share options
share options_webui

Steps to reproduce

  1. Open dolphin
  2. Right click on a folder
  3. Go to Nextcloud context menu and go to Share options
  4. Create a share link and go to share option
  5. Tick the Allow editing box
    ...

Expected behavior

Editing on a folder should allow upload.

Which files are affected by this bug

N/A

Operating system

Linux

Which version of the operating system you are running.

KDE neon 5.27

Package

Other

Nextcloud Server version

25.0.5

Nextcloud Desktop Client version

3.8.0

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 3.4.2 to 3.4.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

  • Default internal user-backend
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Nextcloud Server logs

No response

Additional info

Operating System: KDE neon 5.27
KDE Plasma Version: 5.27.4
KDE Frameworks Version: 5.105.0
Qt Version: 5.15.8
Kernel Version: 6.1.22 (64-bit)
Graphics Platform: Wayland

@tom2tester
Copy link

Same problem on WINDOWS and macOS clients since the latest 3.7 client versions. I can't specify which version "introduces" this bug, but definitely in 3.7.x!

@avatar1024
Copy link
Author

avatar1024 commented Apr 19, 2023

Same behaviour in client version 3.8.1 and with NC server 26.0.1

@avatar1024
Copy link
Author

Seems to me that the default share options should be the "Bundled permissions" (Read only, Allow upload and editing, File drop) and not the "Custom Permissions" (Upload, Edit , Delete)

@avatar1024 avatar1024 changed the title [Bug]: Missing upload as share option for folders - can only edit [Bug]: Share options for folders uses "Custom permissions" instead of "Bundled permissions" - can only edit and not upload Apr 20, 2023
@gtntdev
Copy link

gtntdev commented Apr 22, 2023

same issue here!

1 similar comment
@omel78
Copy link

omel78 commented Apr 24, 2023

same issue here!

@mjunghanns
Copy link

Same here!

@avatar1024
Copy link
Author

I have now checked the behaviour in the android app and there the share option is "Edit and Upload", as it should, and so this issue is only on the desktop client, and indeed a bug.

@joshtrichards
Copy link
Member

Fixed in #5622/#5631 (released in v3.8.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants