[Bug]: i18n: Variables do not work for e. g. Hungarian

[rakekniven]

⚠️ Before submitting, please verify the following: ⚠️

• This is a bug, not a question or a configuration issue.
• This issue is not already reported on Github (I've searched it).
• Nextcloud Server and Desktop Client are up to date. See Server Maintenance and Release Schedule and Desktop Releases for supported versions.
• I agree to follow Nextcloud's Code of Conduct

Bug description

desktop/src/libsync/discovery.cpp

Lines 415 to 421 in f86f5af

	const auto itemTypeName = (isDirectory ? tr("Folder", "name of folder entity to use when warning about invalid name") : tr("File", "name of folder entity to use when warning about invalid name"));
	if (invalid) {
	item->_errorString = tr("%1 name containing the character \"%2\" is not supported on this file system.", "folder or file impossible to sync due to an invalid name, placeholders will be file or folder and the invalid character").arg(itemTypeName, QChar(invalid));
	} else if (isInvalidPattern) {
	item->_errorString = tr("%1 name contains at least one invalid character").arg(itemTypeName);
	} else {
	item->_errorString = tr("%1 name is a reserved name on this file system.").arg(itemTypeName);

"The issue is with %1, this can be either File or Folder. These are at the start of the sentence in English, but e.g. in my language they will be in the middle of the sentence, so I shouldn't capitalize them. I am lucky as this is the case in all three strings, but if it wasn't, I couldn't translate it properly. I am not sure that this could be solved easily in all languages.

More generally, these kind of clever optimizations are not a great idea, and they save very little work for most people (now we have 5 strings instead of 6), while causing issues to others."

Solution would be to have 3 strings for "File" and 3 strings for "Folder".

[Rello]

Hi,

so your suggestion is to get rid of %1 and hardcode the strings with e.g.

• "File name contains at least one invalid character"
• "Folder name contains at least one invalid character"

for understanding, what would be the different translation in HU e.g.?

[rakekniven]

The case.

"The issue is with %1, this can be either File or Folder. These are at the start of the sentence in English, but e.g. in my language they will be in the middle of the sentence, so I shouldn't capitalize them. I am lucky as this is the case in all three strings, but if it wasn't, I couldn't translate it properly. I am not sure that this could be solved easily in all languages."

[Rello]

ah, wait.
you mean "Folder" is a separate string that is translated on its own.
if now - not in this case, but another case - the sentence would be "bla bla bla %1 bla bla bla", then it would replace the capital "Folder" in the middle of the sentence.
Did I get it correctly?

[rakekniven]

Did I get it correctly?

Yes. This is how I understood it from the hungarian translator who reported this issue.