Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't uselessly copy files #1612

Closed
danieljkemp opened this issue Oct 15, 2021 · 1 comment
Closed

Don't uselessly copy files #1612

danieljkemp opened this issue Oct 15, 2021 · 1 comment

Comments

@danieljkemp
Copy link

Currently a check is made against version.php to see if if the current container is newer than the installed version, and if not, application files are copied into a volume. This is inefficient, and bad practice.

In the case of running the apache version, there is no reason to do this; it only serves to waste space on the volume store, and slow install/upgrade times.

In the case of running the fpm version, this is still a hack; files required by the nginix/lighttpd servers should be copied in manually (replicate the old behavior in an init container), or via docker's behavior when mounting a volume on a directory. The better solution would be to create a new image that runs a pre-configured/configurable nginx bassed off of this image -- any required configs could then be shared in a volume.

@alallier
Copy link

alallier commented Jan 4, 2022

Related to #340

@J0WI J0WI added the duplicate label Mar 28, 2023
@J0WI J0WI closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants