Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx example configs: minor suggestions/ideas #194

Closed
nickvergessen opened this issue Sep 28, 2016 · 4 comments · Fixed by #10423
Closed

nginx example configs: minor suggestions/ideas #194

nickvergessen opened this issue Sep 28, 2016 · 4 comments · Fixed by #10423

Comments

@nickvergessen
Copy link
Member

Reported by @voidzero in nextcloud/server#1552

@voidzero
Copy link

Which branch should I update? Not sure if I should use stable9, or master.

@nickvergessen
Copy link
Member Author

master, we will copy the changes to the other branches afterwards

@tflidd
Copy link
Contributor

tflidd commented Aug 24, 2017

A short list of change requests:

@joshtrichards
Copy link
Member

  • The permissions of htaccesstest.txt is moot due to Properly check the data dir server#2513 (and there's no need to mess with the example at the moment IMO since it's really just an example for "what to do if you're logs have misc crud in them" - if anything I'd remove that section entirely since it's not NC specific and really just generic NGINX/system admin stuff. Well, or maybe make the example reference a random URL other than htaccesstest.txt I guess so as to avoid confusion)
  • upload settings: Submitted PR Link Big File handling section from nginx chapter in the existing uploading files >10MB section #10423 to address that
  • Temporary redirect stuff is debatable and, in any case, the nginx config is modeled after the core .htaccess which currently uses 301. Any consideration to changing in in the nginx doc would only be a byproduct of doing so in core and there's no serious demand to do so so I'd consider this issue basically closed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants