-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add sub config for TypeScript projects #433
Conversation
Can't we just support typescript out of the box? |
fe3b7ce
to
a2a10c9
Compare
@skjnldsv Good point! I changed it to simply use |
3c39fea
to
040875a
Compare
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
This is the same behavior as for js file, why should we treat ts file differently regarding documentation? Edit: await new Promise((resolve, reject): any => docker.pull(SERVER_IMAGE, (_err, stream) => {
some(onFinished);
/**
*
* @param err
* @param output
*/
function onFinished(err, output) {
// ... This can be rewritten to prevent es-lint complaing about missing documentation of await new Promise((resolve, reject): any => docker.pull(SERVER_IMAGE, (_err, stream) => {
const onFinished = (err, output) => {
}
some(onFinished); |
Ah right, typing requirements is bad, but param documentation is still quite good to have! 👍 |
parser: '@typescript-eslint/parser', | ||
}, | ||
rules: { | ||
'n/no-missing-import': 'off', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@susnux why disabling this rule btw?
If we cannot resolve, maybe it's bad?
This adds a sub-config for typescript projects, e.g. we could use it within our libraries or for users which use TypeScript for app development (vue + ts is pretty common nowadays).