Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shareing web link, can’t restrict IP with “File access control” #309

Open
leonids23 opened this issue Feb 20, 2023 · 6 comments
Open

Comments

@leonids23
Copy link

File access control
Hi, I have set up “File access control” to restrict access to files or folders permissions only to specific IP addresses.
However, today I found that when using the file sharing link feature, it does not block any IP addresses.
Is this a bug in the current version?
I have tested this before on version 18 or so, and at that time, the sharing link could not be accessed by IPs that were not specified in the access control settings.
But today I found that this feature is not working.
Is there a solution to this problem?
Thank you.

File access control version:1.15.1

Running Nextcloud 25.0.3.2

@nickvergessen
Copy link
Member

Can you post your full rules? Mostlikely it's not about the IP but the other part of the checks

@leonids23
Copy link
Author

Hi,The rule is as follows: it only applies to the inability to download and upload files after logging in to the account. However, as long as the "share" function is used for the file, all IPs can download it.
image

Can you post your full rules? Mostlikely it's not about the IP but the other part of the checks

@nickvergessen
Copy link
Member

Well there is a user group check. Guests are never part of a user group so the rule never matches?

@leonids23
Copy link
Author

However, the downloaded files used by guests are shared by the user group. Previously, guests could indeed be restricted by their IP address, but now they cannot. Additionally, why is there only a restriction on groups and not on "individual accounts"? This has led me to want to restrict IP addresses, so I created a group with the same name as each account.

Well there is a user group check. Guests are never part of a user group so the rule never matches?

@nickvergessen
Copy link
Member

However, the downloaded files used by guests are shared by the user group.

The groups are only considered for the accessing user, not the owner. Guests are never in a group so it doesn't match.

There is no user rule as groups can be used for that. Could of course be added, but that is really specific and therefore not worth the efforts so far.

@leonids23
Copy link
Author

However, the downloaded files used by guests are shared by the user group.

The groups are only considered for the accessing user, not the owner. Guests are never in a group so it doesn't match.

There is no user rule as groups can be used for that. Could of course be added, but that is really specific and therefore not worth the efforts so far.

Thank you for your reply. Is there any way to restrict the "Eason" user group to connect only from a specific IP address and limit the "Eason" group to allow only specific IP addresses to download files or folders shared by them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants