Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud Files : Poor UX for indication of sharing origins and locking in list mode #350

Closed
Jerome-Herbinet opened this issue Jul 29, 2024 · 8 comments · Fixed by #471
Closed

Comments

@Jerome-Herbinet
Copy link
Member

Jerome-Herbinet commented Jul 29, 2024

In the file list, the profile picture (or initials, if there is no profile picture) of the user responsible for sharing and/or locking appears on the line of the file(s) concerned.

The problem is that unless you hover the cursor over the profile image, you don't actually know what it corresponds to, and so you wonder why these profile images appear.

Historically, it seems to me that the image of the user behind a share has been appearing in Nextcloud for a long time, and this is acceptable if it's the only case where it appears. But in my opinion it becomes a big UI/UX problem when two images appear side by side, one concerning the received share and the other concerning the lock, because as already said, unless you hover over them, you have no direct and intuitive way of knowing what they mean...

I think the interface needs to be improved here to make things clearer and more precise; for example, a padlock and a share icon should be added somewhere, respectively in the areas where the share sender and lock initiator are displayed. This applies even if there is only one share and no lock, or vice versa. In other words, the profile image should no longer be left alone without any visual explanation, and from a UI/UX point of view, a simple tooltip at the cursor position is insufficient, even if there's a notion of the column to help understand what it's all about.

The share and/or lock icon should be displayed as an overlay on top-right of the profile or initial image (with a higher z-index).

2024-07-29_13-42
2024-07-29_13-43

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@Jerome-Herbinet
Copy link
Member Author

@nextcloud/designers

@jancborchardt
Copy link
Member

We could show a little "Edit" pencil icon (or pencil lock icon) on the bottom right of the avatar of the person who is responsible for locking the file?

Also yes, a viable alternative would be to just show the lock icon and not any avatar for the person who locked it – wasn’t this how it was before @juliushaertl? Cause those details are shown in the action menu.

@juliusknorr
Copy link
Member

The reason we switched to an avatar was to differentiate between a user lock and a collaborative lock while potentially multiple people are in text or Collabora.

But I see this might be confusing, maybe we use those instead

Manual user lock https://pictogrammers.com/library/mdi/icon/account-lock/
Collaborative lock https://pictogrammers.com/library/mdi/icon/pencil-lock/

What do you think about that?

@jancborchardt
Copy link
Member

@juliushaertl does a manual user lock expire after some time (30 mins)? If so I would say let’s use these:

Please note we should use the original Material Symbols rather than Pictogrammers to look for icons, as sooner or later we need to move over.

@juliusknorr
Copy link
Member

@juliushaertl does a manual user lock expire after some time (30 mins)? If so I would say let’s use these:

By default not, but can be configured by admins. We can use this one when a timeout is configured but the lock_person one does not fit well in my opinion.

@jancborchardt
Copy link
Member

@juliushaertl ok, then I’m fine going with your icon suggestions. :)

@juliusknorr
Copy link
Member

juliusknorr commented Aug 28, 2024

@jancborchardt Since we recently had discussions in our planning call around if we want to work towards indicating currently active users on a document rather then share owner, maybe we should actually reconsider showing the avatar there for the share itself?

Ref nextcloud/server#43763 (comment)

  • Indicate active collaboration in the files list (for text/collabora/whiteboard)
    • Partly already there with files_lock app but not real time

@jancborchardt
Copy link
Member

@juliushaertl right, but I would say let's get that collaborator display implemented before we get rid of the share owner display. Otherwise we'll have no avatar indicator and that's also not nice.

@juliusknorr juliusknorr transferred this issue from nextcloud/server Aug 29, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Nov 14, 2024
@juliusknorr juliusknorr moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Nov 14, 2024
@jancborchardt jancborchardt moved this from 👓 Design review to 🏗️ At engineering in 🖍 Design team Nov 14, 2024
@juliusknorr juliusknorr self-assigned this Nov 14, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team Dec 19, 2024
@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 📝 Office team Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Status: 🎉 Done
Development

Successfully merging a pull request may close this issue.

3 participants