Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nextcloud/viewer #159

Closed
szaimen opened this issue Nov 8, 2019 · 11 comments
Closed

Use nextcloud/viewer #159

szaimen opened this issue Nov 8, 2019 · 11 comments

Comments

@szaimen
Copy link
Collaborator

szaimen commented Nov 8, 2019

Please enable us to open pdf files with the viewer app. Would be really awesome beeing able to open pdf files also in other apps like e.g. nextcloud mail for attachments. :)
This is possible since nextcloud/viewer#271

@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2019

I guess it make sense for pdf since it's read only yes :)

@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2019

Though It should probably go into the files_pdfviewer app

@skjnldsv skjnldsv transferred this issue from nextcloud/viewer Nov 8, 2019
@szaimen szaimen changed the title Add support for PDF files Please enable us open pdf files with the viewer app Nov 8, 2019
@szaimen szaimen changed the title Please enable us open pdf files with the viewer app Please enable us to open pdf files with the viewer app Nov 8, 2019
@skjnldsv skjnldsv changed the title Please enable us to open pdf files with the viewer app Use nextcloud/viewer Nov 8, 2019
@juliusknorr
Copy link
Member

I've heard that @danxuliu has been trying to move files_pdfviewer to webpack and update pdfjs so once that has some usabale state it could make use of viewer to integrate in the file list.

@szaimen
Copy link
Collaborator Author

szaimen commented Aug 2, 2020

@danxuliu is there any update concerning this? :)

@danxuliu
Copy link
Member

It is high in my TODO, but unfortunately there have been other things with a higher priority on top ;-) But hopefully I will find some time to work on it soon™

@skjnldsv
Copy link
Member

Done

@szaimen
Copy link
Collaborator Author

szaimen commented Aug 13, 2020

Wow that was fast 🎉

@skjnldsv
Copy link
Member

skjnldsv commented Aug 13, 2020

I broke my brain for two days trying to implement everything without an iframe and proper library, it's not feasible.

So I went back, and implemented the iframe frontend from scratch. Now it's at least super clean and faster :)

@onny
Copy link

onny commented Aug 13, 2020

Wow that sounds impressive, could you share an screenshot? :O :D

@skjnldsv
Copy link
Member

I'm out for the day :)
It will be part of nc20
It's basically just integrated into the Viewer that displays all the images, videos... Etc 🥳

@onny
Copy link

onny commented Oct 10, 2020

With a few css styling fixes one could get rid of the dysfunctional close button and the background pattern in pdfjs 👍

20201010_10h05m01s_grim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants