Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust pdfviewer theming based on accessibility usersetting #204

Open
szaimen opened this issue Aug 19, 2020 · 2 comments
Open

Adjust pdfviewer theming based on accessibility usersetting #204

szaimen opened this issue Aug 19, 2020 · 2 comments
Labels
1. to develop design enhancement good first issue papercut

Comments

@szaimen
Copy link
Collaborator

szaimen commented Aug 19, 2020

Hi,

The following PR will probably soon be merged: mozilla/pdf.js#11077 which will bring theming support and a light and dark mode, afaik.

So I guess it would be great if the theming could be automatically toggled depending on the accessibility usersetting (dark/normal).

Cheers!
@skjnldsv
Copy link
Member

Yep, we need to adapt it a bit. We're discussing wether implement it on top of server styling (overriding both server and pdf.js css, or just not ship any server styling and only adapt the default pdf.js styling) see #202

@szaimen
Copy link
Collaborator Author

szaimen commented Nov 10, 2021

This could maybe make use of nextcloud/viewer#1051 like text is now doing nextcloud/text#1907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop design enhancement good first issue papercut
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skjnldsv @szaimen