-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDF-viewer not full-screen anymore on NC28 #843
Comments
Strangely enough I have not been able to reproduce the double scroll bar issue, but it should be caused by the same change that made the PDF viewer to no longer be shown in full screen. Maybe it depends on the PDF file, I do not know 🤷 In any case, the problem is that, although the viewer is "framed" and leaves a small space at the bottom, the iframe of the PDF viewer overflows it and uses the full height of the viewer (leaving a margin at the top for the header). However, in Nextcloud 28, NcModal sets Note that
Setting |
Adjusted #845. Should work now without any viewer fix :) |
@danxuliu I tested this and it works fine generally but I don't know why and if it is caused by this PR but somehow the pdf viewer has two scrollbars now:
Reproduced on NC28
Originally posted by @szaimen in #787 (review)
The text was updated successfully, but these errors were encountered: