-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RTL and preferably, bidi support #1637
Comments
This would be a great addition, I think there are just a few places where RTL works. Edit: I roughly checked our CSS, I think as soon as we add |
Mostly yes, but not enough. There are a few cases of using values like |
But I would like to suggest using And I would say, this should happen regardless of the direction used in NextCloud by the person creating the form. If it sounds complex, let us work on it. I am gathering a group of Iranians to work for a couple of weeks to improve NextCloud and its apps' support for RTL languages (to be more precise, support for bidirectional text support. |
Comment from @ahangarha nextcloud-libraries/nextcloud-l10n#639 (review)
|
So I tested a bit, sadly I do not speak any RTL language so I highly appreatiate any help by you @ahangarha :)
Am I correct @ahangarha ? Because currently if I set my language to Arabic, which is RTL, it looks wrong, the text seems to be left aligned.
Note the wrong paddings and margins in the second image because of the |
@ahangarha Besides using |
@susnux You have done a pretty good job! The PR looks good. One point is that regardless of the global direction of the page, form should show text in correct direction. |
Nextcloud:
Is your feature request related to a problem? Please describe.
Currently, there is no support for RTL or bidi (bidirectional text) support. As a result, LTR is the enforced direction for the form.
Describe the solution you'd like
text-align: start
orpadding-inline-start
,...) can help to not bring complication to the styling.Describe alternatives you've considered
A custom CSS field for customizing the form would be also good, but this is entirely another feature.
Additional context
I don't think it be needed unless you need my help with bidirectional text support.
Regards
The text was updated successfully, but these errors were encountered: