Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Implement a search engine #16

Open
1 task done
oparoz opened this issue Sep 4, 2016 · 2 comments
Open
1 task done

Implement a search engine #16

oparoz opened this issue Sep 4, 2016 · 2 comments
Labels
discussion Being discussed enhancement New feature or request

Comments

@oparoz
Copy link
Member

oparoz commented Sep 4, 2016

From @oparoz on February 21, 2015 14:22

Nextcloud comes with a search engine, but the app is not yet plugged into it.

Thoughts on possible solutions

As soon as a search is started, the view and models should be cleared and thumbnails should be generated.

  • If we keep the current way of building the view, then nothing might show up until a row is full.
  • If we make it so that a search is authorised to ask the backend for one thumbnail as a time, then that backend may get flooded with requests (that's what the Files app is doing)

Prerequisites

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Copied from original issue: owncloud/gallery#36

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

From @theCalcaholic on June 11, 2015 17:0

What do you mean by "a row is full"? A row of search results or generated Thumbnails?

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

This is the way it currently works

  1. We get a list of all media files we need to show
  2. We split the list in batches
  3. We show a row of thumbnails once all thumbnails for that row have been received

This works kind of OK when we know in advance what we need to show in the view (via step 1)

The search app is sending back results as soon as we type a few letters, but we wouldn't be able to show anything until we get the thumbnails from the server whereas the Files app is first building the DOM and then asking for thumbnails.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discussion Being discussed enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants