-
Notifications
You must be signed in to change notification settings - Fork 58
Switch to PhotoSwipe for the slideshow #33
Comments
@jancborchardt - Feel free to provide your input on PhotoSwipe. At some point we'll have to decide whether it's best to work on our custom slideshow or improve on an existing solution. |
From @jancborchardt on June 26, 2015 19:9 Phew, good question … in general it seems better to take a widely-used library for stuff like this rather than baking our own. Are there any alternatives? Maybe @owncloud/designers know something? |
The other software I tested was Fotorama, but it's too basic from my pov. |
It seems the Bigshot project has died and since we're not really using its advanced features, I think we should seriously consider switching to Photoswipe. |
From @kavishdahekar on March 2, 2016 17:36 If we proceed with Hammer.js for zooming capability, modifying BigShot to fix |
Thank you @kavishdahekar. Don't hesitate to ask questions if you don't understand how some things are currently done in the slideshow because the candidate will need to understand how to migrate features from one engine to the other or how to keep the current UI on top of the view generated by the engine per example. |
From @shubhrajodiya on March 16, 2016 17:9 @oparoz i am unable to understand where to start up with this i am having a lot of ideas regarding the slideshow but unable to find a path to integrate it in ownCloud |
@shubhrajodiya @kavishdahekar - I've created a new issue to describe what should be attempted during the GSoC. It contains more details and useful links which should help you figure out how things are initialised. |
Superseded by #540 |
From @oparoz on May 23, 2015 15:38
It was suggested that PhotoSwipe could be a replacement, so I took a look at the API and did a rough implementation.
Here are my findings:
+
It supports quite a few features which were manually added to the Gallery slideshow and solves some of the complaints mentioned above
-
The initialisation doesn't work out of the box because we don't have the image dimensions before launching the slideshow
My biggest problem is with the missing scroll to zoom feature on the desktop, but if it's not on/off with gestures, it should be possible to get it to work on desktops as well.
Sponsorship
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
Copied from original issue: owncloud/gallery#158
The text was updated successfully, but these errors were encountered: