Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud 25 Support #161

Closed
AndyXheli opened this issue Sep 2, 2022 · 22 comments
Closed

Nextcloud 25 Support #161

AndyXheli opened this issue Sep 2, 2022 · 22 comments

Comments

@AndyXheli
Copy link

No description provided.

@neufeind
Copy link

Compatibility version is already raised, but we're missing a release it seems? Just stumbled over this, since now Nextcloud 25 is actively rolled-out and this (as well as other plugins) are missing a compatible release on apps.nextcloud.com.

@AndyXheli

This comment was marked as off-topic.

nickvergessen referenced this issue Oct 24, 2022
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nursoda
Copy link

nursoda commented Nov 5, 2022

25.0.1 is out, please update. If I "allow untested", Impersonate works perfectly fine for me on NC25.

@solracsf solracsf pinned this issue Nov 20, 2022
@resposit

This comment was marked as off-topic.

@ksteinb

This comment was marked as off-topic.

@GitBaer

This comment was marked as off-topic.

@pgassmann
Copy link

Nextcloud 25.0.2 is now recommended on the stable channel.

@nickvergessen can you provide some transparency why this official app by Nextcloud GmbH is not released for the current stable version?

@BurtGummer
Copy link

I think this functionality belongs in the main version.

@livier
Copy link

livier commented Jan 13, 2023

I think this functionality belongs in the main version.

Impersonate would be obsolete ?
and any Nextcloud instance would permit it without this app ?

Did not found how to make the same thing without it.
Say how please ...

@christianlupus
Copy link

As far as I understood him, this functionality should be part of the core instead of an app. It is not yet so. But it is a tool for the admins to help in case a user has a problem.

@livier
Copy link

livier commented Jan 13, 2023

ok, excuse my frenchglish ... should / would ...
I know it's for admins, I use it for that. And I'll "allow untested" next time I'll need it if not updated before.
Not sure it's a good idea to make it part off the core. Mayde some admins do not need it or it could be forbidden by some security policy ...

@DriedPlumber
Copy link

This should be part of the core instead of an app.
Next time I will not update NextCloud as long as the apps are not updated...

@nursoda
Copy link

nursoda commented Jan 19, 2023

Yes, checking whether all apps that are important to you are supported prior to upgrading is a good idea. The web updater even tells you what would be "incompatible" afterwards.

That said, for most small apps, a simple "allow untested" will do as breaking changes are rather rare.

To even catch these, you should run a test instance, e.g. in a subfolder. There you may easily test without sacrificing your production data.

But…such rants and infos should rather be posted in the forum. If anyone feels that it needs a discussion thread, please open one there and link it here.

@jmigual
Copy link

jmigual commented Jan 21, 2023

@blizzz would it be possible to add a release of this app for Nextcloud 25 in the Nextcloud store?

@guillemsuetta
Copy link

@blizzz would it be possible to add a release of this app for Nextcloud 25 in the Nextcloud store?

Any time estimate when the release of the app for Nextcloud 25 will be on the Nextcloud store?

@AndyXheli
Copy link
Author

All, I'm running it on NC 25.0.3 with PHP 8.1 and done have any issues.

@dirdi
Copy link

dirdi commented Jan 27, 2023

I suspect there could be a not yet disclosed bug and one does not want to release a new version until this bug was fixed.

@beyercenter
Copy link

beyercenter commented Jan 29, 2023

no one assigned, so no one will do anything :-(

@blizzz can some one please release this???

@livier
Copy link

livier commented Jan 29, 2023

this app is following a branched pattern. There is a stable branch for each Nextcloud major version.
It's just missing a release from there

This app seem ready for Nextcloud 25 and 26 !

Who can release ?
If nobody available for that, can anybody check if there are changes between releases 1.11 ; 1.12 and 1.13, and if this changes could damage something ? (I'm not used to using GitHub to be able to do this).
We would be safe for "allow untested"

@canonex
Copy link

canonex commented Feb 9, 2023

Yes, this plugin is very handy:
I'm still on Nextcloud 24 because of this missing update.

@R0Wi
Copy link
Member

R0Wi commented Feb 21, 2023

this app is following a branched pattern. There is a stable branch for each Nextcloud major version. It's just missing a release from there This app seem ready for Nextcloud 25 and 26 !

Who can release ? If nobody available for that, can anybody check if there are changes between releases 1.11 ; 1.12 and 1.13, and if this changes could damage something ? (I'm not used to using GitHub to be able to do this). We would be safe for "allow untested"

Can confirm that the code of stable25 works in a NC25 instance. If you have a look at the diff between the latest release v1.11 (which is for NC24) and the current stable25, you'll see that only the app metadata, CI/CD related stuff and many localizations have changed. So no "real" code changes here (which is expected, I'm also an app developer and I did not need to change much to make my app compatible with NC25). What you could do is either activate v1.11.0 from the NC app store as "enable untested app" or download the app yourself:

cd <YOUR_NC_ROOT>/apps
wget https://github.com/nextcloud/impersonate/archive/refs/heads/stable25.zip
unzip stable25.zip
mv impersonate-stable25 impersonate
# Change this to match the user running your webserver
chown -R www-data:www-data impersonate

I did the latter and it all works as expected. Just one thing to note: the UI has changed a little bit so you can access the impersonate-button through the three-dots menu now (not like shown in the docs screenshot)

image

@blizzz
Copy link
Member

blizzz commented Feb 28, 2023

just published, also against 26.

@blizzz blizzz closed this as completed Feb 28, 2023
@blizzz blizzz unpinned this issue Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests