Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connects to github but throws errors in logs and on widget #83

Closed
Haui1112 opened this issue Jul 19, 2023 · 4 comments
Closed

Connects to github but throws errors in logs and on widget #83

Haui1112 opened this issue Jul 19, 2023 · 4 comments
Labels
bug Something isn't working question Further information is requested

Comments

@Haui1112
Copy link

Hi there,
I'm running NC 27 in Docker behind a local ssl nginx reverse proxy and installed the app today.

  • Connection to Github works (github side recognizes the key being used)
  • But the frontend shows an error "error connecting to github".
  • Meanwhile the logs are spammed with the following error:

Creation of dynamic property OCA\Github\AppInfo\Application::$config is deprecated at /var/www/html/custom_apps/integration_github/lib/AppInfo/Application.php#42
and
Creation of dynamic property OCA\Github\AppInfo\Application::$container is deprecated at /var/www/html/custom_apps/integration_github/lib/AppInfo/Application.php#41

I'm not sure how to proceed. Let me know if you need anything. Thank you for making this project in the first place.
Have a good one!

@julien-nc julien-nc added bug Something isn't working question Further information is requested labels Jul 20, 2023
@julien-nc
Copy link
Member

Hi, thanks for the bug report.

Looking at the implementation, I guess you're seeing this error message in the dashboard.
There might be more information in the response of the request getting the notifications. Could you check that?

  • Open the browser dev tools (press F12 on most browsers) and go in the network tab
  • Reload the dashboard page
  • Filter the request list (in the network tab) with "github/notifications"
  • You should see one request, select it
  • Check the content of the response tab

Creation of dynamic property OCA\Github\AppInfo\Application::$config is deprecated

It's been fixed already but is not released yet.

@Haui1112
Copy link
Author

Hi there!

It was user error. Github has both standard tokens and "finegrained tokens". I misclicked and chose the finegrained one. I assume that is why I could make a connection but nothing else.

However, I did change that and now it works like a charm! Thank you for responding, getting that response and revisiting the whole process to search for errors was what made me stumble upon it. :)

Thank you for providing this software and have a wonderful day!

@julien-nc
Copy link
Member

Thanks for the feedback.

@mig5
Copy link

mig5 commented Jul 25, 2023

That's not great for people who care about security, though - does that mean this plugin doesn't work with 'fine grained' tokens?

I would rather not have to grant the app/my Nextcloud instance, write permission to private repositories.

See #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants