perf(quick-actions): eliminate dublicate api calld for each envelope

Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>

Author: hamza221

lib/Controller/PageController.php

@@ -238,6 +238,10 @@ public function index(): TemplateResponse {
 			'quick-actions',
 			$this->quickActionsService->findAll($this->currentUserId),
 		);
+		$this->initialStateService->provideInitialState(
+			'quick-actions-processed',
+			$this->quickActionsService->findAllProcessed($this->currentUserId),
+		);
 		$googleOauthclientId = $this->config->getAppValue(Application::APP_ID, 'google_oauth_client_id');
 		if (!empty($googleOauthclientId)) {
 			$this->initialStateService->provideInitialState(

lib/Db/Actions.php

@@ -22,10 +22,22 @@
 class Actions extends Entity implements JsonSerializable {
 	protected $name;
 	protected $accountId;
+	protected $actionSteps;
+	protected $icon;
 
 	public function __construct() {
 		$this->addType('name', 'string');
 		$this->addType('accountId', 'integer');
+		$this->addType('actionSteps', 'array');
+		$this->addType('icon', 'string');
+	}
+
+	public function setActionSteps(array $actionSteps): void {
+		$this->actionSteps = $actionSteps;
+	}
+
+	public function setIcon(string $icon): void {
+		$this->icon = $icon;
 	}
 
 	#[ReturnTypeWillChange]
@@ -34,6 +46,8 @@ public function jsonSerialize() {
 			'id' => $this->getId(),
 			'name' => $this->getName(),
 			'accountId' => $this->getAccountId(),
+			'actionSteps' => $this->actionSteps,
+			'icon' => $this->icon,
 
 		];
 	}

lib/Service/QuickActionsService.php

@@ -43,6 +43,19 @@ public function __construct(
 	public function findAll(string $userId): array {
 		return $this->actionsMapper->findAll($userId);
 	}
+	/**
+	 * @param string $userId
+	 * @return Actions[]
+	 */
+	public function findAllProcessed(string $userId): array {
+		$actions = $this->actionsMapper->findAll($userId);
+		foreach ($actions as $action) {
+			$actionSteps = $this->actionStepMapper->findAllStepsForOneAction($action->getId(), $userId);
+			$action->setActionSteps($actionSteps);
+			$action->setIcon($actionSteps[0]->getName());
+		}
+		return $actions;
+	}
 
 	/**
 	 * @throws DoesNotExistException
@@ -82,6 +95,10 @@ public function findAllActionSteps(int $actionId, string $userId): array {
 		return $this->actionStepMapper->findAllStepsForOneAction($actionId, $userId);
 	}
 
+	public function findAllActionStepsForUser(string $userId): array {
+		return $this->actionStepMapper->findAllStepsForUser($userId);
+	}
+
 	/**
 	 * @throws DoesNotExistException
 	 */

src/components/Envelope.vue

@@ -765,16 +765,11 @@ export default {
 			].filter(option => option.timestamp !== null)
 		},
 	},
-	 watch: {
-		storeActions() {
-			this.filterAndEnrichQuickActions()
-		},
-	},
-	async mounted() {
+	mounted() {
 		this.onWindowResize()
 		window.addEventListener('resize', this.onWindowResize)
 		if (this.filteredQuickActions.length === 0) {
-			await this.filterAndEnrichQuickActions()
+			this.filterAndEnrichQuickActions()
 		}
 	},
 	methods: {
@@ -787,37 +782,35 @@ export default {
 		formatted() {
 			return shortRelativeDatetime(new Date(this.data.dateInt * 1000))
 		},
-		async filterAndEnrichQuickActions() {
+		filterAndEnrichQuickActions() {
 			this.filteredQuickActions = []
-			const quickActions = this.mainStore.getQuickActions().filter(action => action.accountId === this.data.accountId)
+			const quickActions = this.mainStore.getQuickActionProcessed().filter(action => action.accountId === this.data.accountId)
 			for (const action of quickActions) {
-				const steps = await findAllStepsForAction(action.id)
-				const check = steps.every(step => {
-					if (['markAsSpam', 'applyTag', 'markAsImportant', 'markAsFavorite'].includes(step.type) && !this.hasWriteAcl) {
+				const check = action.actionSteps.every(step => {
+					if (['markAsSpam', 'applyTag', 'markAsImportant', 'markAsFavorite'].includes(step.name) && !this.hasWriteAcl) {
 						return false
 					}
-					if (['markAsRead', 'markAsUnread'].includes(step.type) && !this.hasSeenAcl) {
+					if (['markAsRead', 'markAsUnread'].includes(step.name) && !this.hasSeenAcl) {
 						return false
 					}
-					if (['moveThread', 'deleteThread'].includes(step.type) && !this.hasDeleteAcl) {
+					if (['moveThread', 'deleteThread'].includes(step.name) && !this.hasDeleteAcl) {
 						return false
 					}
 					return true
 				})
-				if (check) {
-					this.filteredQuickActions.push({
-						...action,
-						steps,
-						icon: steps[0]?.name,
-					})
-				}
+			if(check) {
+			this.filteredQuickActions.push({
+				...action,
+			})
+		}
+
 			}
 		},
 		async executeQuickAction(action) {
 			this.closeQuickActionsMenu()
 			this.quickActionLoading = true
 			try {
-				for (const step of action.steps) {
+				for (const step of action.actionSteps) {
 					switch (step.name) {
 					case 'markAsSpam':
 						await this.onToggleJunk()

src/init.js

@@ -88,6 +88,7 @@ export default function initAfterAppCreation() {
 	})
 
 	mainStore.setQuickActions(loadState('mail', 'quick-actions', []))
+	mainStore.setQuickActionsProcessed(loadState('mail', 'quick-actions-processed', []))
 
 	const accountSettings = loadState('mail', 'account-settings')
 	const accounts = loadState('mail', 'accounts', [])

src/store/mainStore.js

@@ -110,6 +110,7 @@ export default defineStore('main', {
 			myTextBlocks: [],
 			sharedTextBlocks: [],
 			quickActions: [],
+			quickActionsProcessed: [],
 		}
 	},
 	getters: {

src/store/mainStore/actions.js

@@ -2372,6 +2372,9 @@ export default function mainStoreActions() {
 		setQuickActions(quickActions) {
 			this.quickActions = quickActions
 		},
+		setQuickActionsProcessed(quickActionsProcessed) {
+			this.quickActionsProcessed = quickActionsProcessed
+		},
 		patchQuickActionLocally(quickAction) {
 			const index = this.quickActions.findIndex(s => s.id === quickAction.id)
 			if (index !== -1) {
@@ -2493,5 +2496,8 @@ export default function mainStoreActions() {
 		getQuickActions() {
 			return this.quickActions
 		},
+		getQuickActionProcessed(){
+			return this.quickActionsProcessed
+		}
 	}
 }