Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail layout div quite small #2870

Closed
DorianVasco opened this issue Apr 6, 2020 · 11 comments
Closed

Mail layout div quite small #2870

DorianVasco opened this issue Apr 6, 2020 · 11 comments

Comments

@DorianVasco
Copy link

Expected behavior

The content window of the selected mail should resize responsively to the browser size.

Actual behavior

Untitled-1
The width and height of the content window are quite contrained to a small size.

Mail app

Mail app version: 1.1.4

Mailserver or service: self hosted / postfix / dovecot

Server configuration

Nextcloud Version: 18.0.3

Client configuration

Browser: Firefox 74

@jancborchardt
Copy link
Member

The height issue is fixed with #2222 and will be in the next release. :)

The width is a design decision as per #2429 (comment)

The width restriction is indeed intentional, as per #2180
Further reading on the cognitive science basis on that at https://en.wikipedia.org/wiki/Line_length


What we could indeed improve is the way that HTML mails with such an extra container (the grey space) are handled. Not sure if this is possible at all though – @DorianVasco @nextcloud/mail any idea?

@jancborchardt jancborchardt removed their assignment Apr 6, 2020
@winkler-winsen

This comment has been minimized.

@jancborchardt

This comment has been minimized.

@winkler-winsen

This comment has been minimized.

@icewind1991
Copy link
Member

The height is still an issue with 1.5.0

image

@ChristophWurst
Copy link
Member

We're running in circles but let me explain one more time: it's technically not possible to have an iframe auto-adjust its height. The only way to do this is by injecting javascript into the iframe, but since we show potentially dangerous content, we have our iframe run in sandbox mode, so no javascript is allowed. This make it impossible to apply this trick.

If one day there is a css/html/whatever change that allows the automagic resizing of iframes (with changing height as images load and all the other edge cases) we might be more lucky. But until then I see no technical solution.

If you know a trick, tho, let us know 🙏

@icewind1991
Copy link
Member

you can have the iframe adjust to it's containers height though

@ChristophWurst
Copy link
Member

Mind sharing more info or a guide explaining this?

@crdxfire
Copy link

@ChristophWurst Yesterday I upgrade to nc20, mail v1.5.0. we've discussed this already months ago and after an update back then, mail display was absolutely ok. for some reason with the update yesterday html content is now only displayed roughly only ~300px high. What happened!?

@ChristophWurst
Copy link
Member

Threading happened. We could previous work around the problem by giving the message as much space as it needed without caring about any overflow on the button (hence a floating attachments icon). It was never a real solution but more of a workaround. Now that we have threads and very likely content below a message we have to prevent the overflow again.

That is why we have this regression.

We're not breaking this just for fun.

@st3iny
Copy link
Member

st3iny commented Nov 8, 2020

Resolved by #3904

@st3iny st3iny closed this as completed Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants