Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make app compatible with NC v25 #1943

Closed
rakekniven opened this issue Oct 19, 2022 · 9 comments
Closed

Make app compatible with NC v25 #1943

rakekniven opened this issue Oct 19, 2022 · 9 comments
Labels

Comments

@rakekniven
Copy link
Member

Today NC25 is out and this app needs some love ❤️ .

@rakekniven rakekniven added the bug label Oct 19, 2022
@SMillerDev
Copy link
Contributor

Duplicate of #1932 and #1845

@SMillerDev SMillerDev closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2022
@rakekniven
Copy link
Member Author

Hello Sean,

#1932 is about a bug
#1845 is about UI things with NC25

My issue is about making news app available for NC25 and therefor no dup IMHO.

@rakekniven rakekniven reopened this Oct 20, 2022
@SMillerDev
Copy link
Contributor

It doesn't work on nextcloud 25 because of those things, it's a duplicate.

@SMillerDev SMillerDev closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2022
@rakekniven
Copy link
Member Author

Ok, I filed such issues on many repos and they are handled different. A milestone would be good to have. But anyway ...

I will happily use the app whenever it is ready for NC25.

@SMillerDev
Copy link
Contributor

Milestone would require someone to actually work on the web UI to resolve the issues. It'll be ready for NC25 if we ever find someone willing to put in the time or when we drop the web UI.

@rakekniven
Copy link
Member Author

we drop the web UI

How to use the app in the browser without an UI?

@Grotax
Copy link
Member

Grotax commented Oct 20, 2022

Yea milestones are basically useless for this app. I tried using it a few times thinking it would help to organise the work going on but there is so little work going on that a milestone is not needed.

We have one big (a bit outdated) branch for the Vue rewrite to which one person has contributed a few times but so far not enough to use it.

And then another one that was formed from that but after that nothing happened.

So there is no active work going on. We could of course release the app as is for NC25 but that would make people think that the app should work without major bugs.
But since news still uses the original angular js we have finally reached the point that things are not working anymore as intended.

Experienced users may force enable the app. If they only use the api through apps on mobile or desktop they should be fine.
But the UI will not work as intended.

@Grotax
Copy link
Member

Grotax commented Oct 20, 2022

we drop the web UI

How to use the app in the browser without an UI?

Well simply not anymore, news would then become a pure API app.
We unfortunately have had no luck with UI contributions. My personal hope is that if the rewrite is done one day, which seems to be quite complicated. That after that day people will feel more willing to actually fix something (because it's less effort) which maybe takes them one afternoon.

The rewrite has already taken multiple people multiple days.

@rakekniven
Copy link
Member Author

rakekniven commented Oct 20, 2022

Hello Benjamin,

thanks a lot for your detailed answers. Now I understand what is going on.

Well simply not anymore, news would then become a pure API app.

That would be a pity. Using it for many many years now (remember interactions with Bernhard).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants