Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avatar and status fixes #1399

Merged
merged 3 commits into from
Sep 11, 2020
Merged

Avatar and status fixes #1399

merged 3 commits into from
Sep 11, 2020

Conversation

nickvergessen
Copy link
Contributor

Part Bright Dark
hover and active Bildschirmfoto von 2020-09-11 14-07-40 Bildschirmfoto von 2020-09-11 14-08-29
transparent issue in avatar Bildschirmfoto von 2020-09-11 14-07-55 Bildschirmfoto von 2020-09-11 14-08-40

@nickvergessen
Make the avatar shine through on hover and make it black backgrounded…
d068ed6 
… in dark-mode

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Make the border 2px thick
14b0457 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix color for active and hovered elements
df56877 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews feature: avatar Related to the avatar component labels Sep 11, 2020
jancborchardt
jancborchardt approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! :)

@nickvergessen nickvergessen merged commit 0f453af into master Sep 11, 2020
@nickvergessen nickvergessen deleted the avatar-and-status-fixes branch September 11, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@georgehrke georgehrke georgehrke approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: avatar Related to the avatar component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @jancborchardt @georgehrke