Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use the icon on the avatar when there is one #1423

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Only use the icon on the avatar when there is one #1423

merged 1 commit into from
Oct 2, 2020

Conversation

nickvergessen
Copy link
Contributor

@nickvergessen nickvergessen commented Oct 2, 2020 •
edited
Loading

  1. As Alice set yourself to invisible (so you have a status but no icon/message or online-status image)
  2. As Bennet open Talk and check the participant list
Before After
Bildschirmfoto von 2020-10-02 09-55-36 Bildschirmfoto von 2020-10-02 09-54-27

@nickvergessen
Only use the icon on the avatar when there is one
1623f00 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews feature: avatar Related to the avatar component labels Oct 2, 2020
@nickvergessen nickvergessen mentioned this pull request Oct 2, 2020
Merged
@ChristophWurst ChristophWurst merged commit 3bda093 into master Oct 2, 2020
@ChristophWurst ChristophWurst deleted the bugfix/noid/only-use-the-icon-when-there-is-one branch October 2, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: avatar Related to the avatar component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @rullzer @ChristophWurst