Make appSidebar scrollable inside #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
enhancement
skjnldsv
requested review from
nickvergessen,
ChristophWurst,
raimund-schluessler,
korelstar,
julien-nc,
marcoambrosini and
danxuliu
skjnldsv
force-pushed
the
fix/app-sidebar
branch
from
a337e07
to
b284483
Compare
|
I will only have time to look at it on Tuesday. |
skjnldsv
force-pushed
the
fix/app-sidebar
branch
from
b284483
to
4386365
Compare
marcoambrosini
approved these changes
Oct 16, 2020
skjnldsv
force-pushed
the
fix/app-sidebar
branch
from
4386365
to
0635663
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/app-sidebar
branch
from
0635663
to
a6f4880
Compare
12 tasks
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joas told me recently they had to rely on hacks to make the sidebar inner scrollable.
The AppSidebar needs to be as simple as possible, so I made the inner tabs scrollable by default and integrated two new events:
scroll, the tab is being scrolledbottomReached, the tab is scrolled to the bottomI also fixed some variables on the css