Use static emoji picker #1526
Merged
Use static emoji picker #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves constant CPU usage and energy impact when used in Talk app. Also updated to 7.0.7. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
skjnldsv
requested review from
GretaD,
julien-nc,
juliushaertl and
ChristophWurst
and removed request for
georgehrke
julien-nc
approved these changes
Oct 31, 2020
There was a problem hiding this comment.
Yay! I couldn't see any graphical difference between classic and static emoji picker. Totally worth using the static one!
This component is still quite heavy to load. I recently solved a big performance issue in Cospend by using v-if instead of v-show to avoid rendering it multiple times. Rendering 10 emoji pickers (even without triggering them) was taking more than one second. Maybe it's worth mentioning this in nc-vue doc.
Anyway, thanks @PVince81!
skjnldsv
added
4. to release
|
/backport to stable2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves constant CPU usage and energy impact when used in Talk app.
Also updated to 7.0.7.
See nextcloud/spreed#4501 for context about the performance issue and some research about it.
Note: not reproducible on the demo page with the emoji picker, so it might be due to some layout configuration.