Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix settings navigation layout #1713

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Fix settings navigation layout #1713

merged 1 commit into from
Feb 18, 2021

Conversation

marcoambrosini
Copy link
Contributor

Don't ellipsize caption if there's available space.

Signed-off-by: Marco Ambrosini marcoambrosini@pm.me

@marcoambrosini
Fix settings navigation layout
4aecdb5 
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@marcoambrosini marcoambrosini self-assigned this Feb 18, 2021
@marcoambrosini marcoambrosini added 3. to review Waiting for reviews bug Something isn't working component Component discussion and/or suggestion design Design, UX, interface and interaction design labels Feb 18, 2021
ChristophWurst
ChristophWurst approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐘

would have appreciated screenshots but I think this css change is small enough so even I understand it

@skjnldsv
Copy link
Contributor

so even I understand it

😱

@marcoambrosini marcoambrosini merged commit 5c0ac4c into master Feb 18, 2021
@marcoambrosini marcoambrosini deleted the settings-navigation-layout-fix branch February 18, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@PVince81 PVince81 Awaiting requested review from PVince81

@GretaD GretaD Awaiting requested review from GretaD

Assignees

@marcoambrosini marcoambrosini

Labels
3. to review Waiting for reviews bug Something isn't working component Component discussion and/or suggestion design Design, UX, interface and interaction design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcoambrosini @skjnldsv @ChristophWurst