Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve multiselect tag #1718

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Improve multiselect tag #1718

merged 1 commit into from
Mar 9, 2021

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Feb 19, 2021

When we select an item from the multiselect dropdown, the item it is not shown in the input field while the dropdown is active. This bring a lot of confusion to users as they are not sure if they selected smth or not. This PR fixes that.

@GretaD

This comment has been minimized.

@GretaD GretaD self-assigned this Feb 19, 2021
@GretaD GretaD added the 2. developing Work in progress label Feb 19, 2021
@GretaD GretaD force-pushed the fix/multiselect_tag branch 3 times, most recently from 26cac34 to 8233460 Compare February 25, 2021 14:32
@GretaD GretaD requested a review from skjnldsv February 25, 2021 14:32
@GretaD GretaD marked this pull request as ready for review February 25, 2021 14:33
@GretaD GretaD added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 25, 2021
@GretaD GretaD added the enhancement New feature or request label Feb 25, 2021
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capture d’écran_2021-03-01_16-16-12
This seems to conflict with the normal layout 🤔

@GretaD

This comment has been minimized.

@GretaD GretaD force-pushed the fix/multiselect_tag branch 2 times, most recently from 7aab020 to b3b3f94 Compare March 5, 2021 15:00
@GretaD GretaD requested a review from skjnldsv March 5, 2021 15:01
Comment on lines 103 to 105
max-width: 50%;
max-width: fit-content;
max-width: -moz-fit-content;
Copy link
Contributor

@skjnldsv skjnldsv Mar 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?
This doesn't look like it have something to do with this pr :)

Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment, it looks good on the docs and code

Signed-off-by: GretaD <gretadoci@gmail.com>
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look fine

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 9, 2021
@GretaD GretaD merged commit 4649822 into master Mar 9, 2021
@GretaD GretaD deleted the fix/multiselect_tag branch March 9, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants