-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CheckboxRadio component #1875
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
enhancement
New feature or request
3. to review
Waiting for reviews
labels
Apr 23, 2021
skjnldsv
requested review from
ChristophWurst,
raimund-schluessler,
juliusknorr,
julien-nc,
GretaD and
marcoambrosini
April 23, 2021 17:05
skjnldsv
force-pushed
the
enh/checkbox-radio
branch
3 times, most recently
from
April 23, 2021 17:28
1a82eed
to
2edf378
Compare
Wooooooah very nice! :) Sooo good to have this standardized. Some design feedback:
|
skjnldsv
force-pushed
the
enh/checkbox-radio
branch
from
April 23, 2021 18:00
2edf378
to
67052f0
Compare
jancborchardt
approved these changes
Apr 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, works very well now, looks great and is accessible. 👍 design-wise!
skjnldsv
force-pushed
the
enh/checkbox-radio
branch
2 times, most recently
from
April 24, 2021 06:56
96b6695
to
7af8a32
Compare
skjnldsv
force-pushed
the
enh/checkbox-radio
branch
from
April 27, 2021 07:55
7af8a32
to
ab625c7
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
enh/checkbox-radio
branch
from
April 27, 2021 07:56
ab625c7
to
c7e5b37
Compare
ChristophWurst
approved these changes
Apr 27, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few examples: