Allow to append datepicker to body #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
added
3. to review
raimund-schluessler
requested review from
nickvergessen,
georgehrke,
tcitworld,
juliusknorr and
skjnldsv
tcitworld
requested review from
ChristophWurst
and removed request for
georgehrke
skjnldsv
approved these changes
Apr 26, 2021
ChristophWurst
approved these changes
Apr 30, 2021
|
/backport to stable3 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the trivial but imperfect fix for #998. We allow to attach the datepicker to body instead of the parent DOM element, so that the datepicker is not cropped by the AppSidebar.
The good thing about this solution is that the probability of breaking anything is quite low, since the default behaviour is unchanged (the change to the CSS is only necessary, because the datepicker attached to body has no
.mx-datepickercontainer anymore).The bad thing is, that the datepicker will scroll with body when attached to it (but it re-opens at the right position):
I have a more sophisticated solution in #1881 which solves the scrolling problem and works very nicely, but it requires changes to AppSidebar and to the datepicker library we use. I will provide a separate PR for it.