Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loading state to CheckboxRadio #1889

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Add loading state to CheckboxRadio #1889

merged 1 commit into from
Apr 28, 2021

Conversation

skjnldsv
Copy link
Contributor

Peek 27-04-2021 18-53

@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews labels Apr 27, 2021
@skjnldsv skjnldsv added this to the 4.0.0 milestone Apr 27, 2021
@skjnldsv skjnldsv self-assigned this Apr 27, 2021
@skjnldsv skjnldsv added enhancement New feature or request feature: checkbox-radio-switch Related to the checkbox-radio-switch component and removed bug Something isn't working labels Apr 27, 2021
@skjnldsv
Add loading state to CheckboxRadio
f725e38 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the enh/CheckboxRadio-loading branch from 9fcd36d to f725e38 Compare April 27, 2021 17:37
marcoambrosini
marcoambrosini approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
off topic: I think that the hover color should be var(--color-background-hover), we're using the primary light for active items and It would be nice to keep this consistent

@skjnldsv
Copy link
Contributor Author

off topic: I think that the hover color should be var(--color-background-hover), we're using the primary light for active items and It would be nice to keep this consistent

@jancborchardt can you comment here? :)
I'm fine with both

@skjnldsv skjnldsv requested a review from juliusknorr April 28, 2021 11:20
ChristophWurst
ChristophWurst approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

I had to manually do this in some apps and it always made the input jump when there is just a single pixel off between input and replacement image … guess that won't happen again :)

@ChristophWurst ChristophWurst merged commit 42e65b0 into master Apr 28, 2021
@ChristophWurst ChristophWurst deleted the enh/CheckboxRadio-loading branch April 28, 2021 12:13
@skjnldsv skjnldsv mentioned this pull request Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@korelstar korelstar Awaiting requested review from korelstar

@miaulalala miaulalala Awaiting requested review from miaulalala

@jotoeri jotoeri Awaiting requested review from jotoeri

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews enhancement New feature or request feature: checkbox-radio-switch Related to the checkbox-radio-switch component
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @ChristophWurst @marcoambrosini