Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement switch mode to CheckboxRadioSwitch #1890

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Implement switch mode to CheckboxRadioSwitch #1890

merged 1 commit into from
Apr 29, 2021

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Apr 28, 2021 •
edited
Loading

Fix #1710

image

@skjnldsv skjnldsv added 3. to review Waiting for reviews enhancement New feature or request feature: checkbox-radio-switch Related to the checkbox-radio-switch component labels Apr 28, 2021
@skjnldsv skjnldsv changed the title Add loading state to CheckboxRadio Implement switch mode to CheckboxRadioSwitch Apr 28, 2021
@skjnldsv skjnldsv added this to the 4.0.0 milestone Apr 28, 2021
@skjnldsv skjnldsv marked this pull request as ready for review April 28, 2021 11:03
Base automatically changed from enh/CheckboxRadio-loading to master April 28, 2021 12:13
juliushaertl
juliushaertl approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@skjnldsv
Implement switch mode to CheckboxRadioSwitch
866c3c0 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Contributor Author

image

marcoambrosini
marcoambrosini approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@marcoambrosini marcoambrosini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
The only feedback I have is that I find the switch a bit small, could we increase the size of it to match the height of the checkbox and have the width scale proportionally?

@skjnldsv
Copy link
Contributor Author

skjnldsv commented Apr 29, 2021 •
edited
Loading

The only feedback I have is that I find the switch a bit small, could we increase the size of it to match the height of the checkbox and have the width scale proportionally?

Can be easily done here: https://github.com/nextcloud/nextcloud-vue/blob/866c3c030a4a7ebc8203f3e2597fcf12bfe81be7/src/components/CheckboxRadioSwitch/CheckboxRadioSwitch.vue#L268-L270
Ask Jan about it :)

@skjnldsv skjnldsv merged commit c5d79e5 into master Apr 29, 2021
@skjnldsv skjnldsv deleted the enh/switch branch April 29, 2021 10:35
@skjnldsv skjnldsv mentioned this pull request Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@korelstar korelstar Awaiting requested review from korelstar

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@PVince81 PVince81 Awaiting requested review from PVince81

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request feature: checkbox-radio-switch Related to the checkbox-radio-switch component
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Implement switch component
3 participants
@skjnldsv @juliushaertl @marcoambrosini