Add disabled state to RichContenteditable and clean not-working v-model #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
enhancement
skjnldsv
requested review from
nickvergessen,
raimund-schluessler,
juliusknorr,
korelstar and
marcoambrosini
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
marcoambrosini
approved these changes
Apr 29, 2021
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/contenteditable
branch
from
3274abd to
b730e16
Compare
skjnldsv
commented
Apr 29, 2021
| @@ -31,7 +31,7 @@ This component displays contenteditable div with automated @ autocompletion [at] | |||
| <template> | |||
| <div> | |||
| <RichContenteditable | |||
| v-model="message" | |||
| :value.sync="message" | |||
There was a problem hiding this comment.
Fixing the not-working v-model
skjnldsv
commented
Apr 29, 2021
| @@ -352,7 +376,6 @@ export default { | |||
| updateValue(htmlOrText) { | |||
| const text = this.parseContent(htmlOrText) | |||
| this.localValue = text | |||
| this.$emit('input', text) | |||
There was a problem hiding this comment.
Fixing the not-working v-model
skjnldsv
changed the title
skjnldsv
changed the title
|
Ping! |
juliusknorr
approved these changes
May 4, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order: normal,
contenteditable=false,disabled=true