Add proper opening/opened/closing/closed events & fix events docs #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
enhancement
skjnldsv
requested review from
ChristophWurst,
raimund-schluessler,
juliushaertl and
marcoambrosini
skjnldsv
force-pushed
the
enh/AppSidebar-event
branch
2 times, most recently
from
d5e95a7
to
8225e17
Compare
skjnldsv
commented
May 3, 2021
Comment on lines
-715
to
-731
|
|
||
| .fade-leave-active, | ||
| .fade-enter-active { | ||
| position: absolute; | ||
| top: 0; | ||
| left: 0; | ||
| width: 100%; | ||
| transition-duration: var(--animation-quick); | ||
| transition-property: opacity; | ||
| opacity: $opacity_full; | ||
| } | ||
|
|
||
| .fade-enter, | ||
| .fade-leave-to { | ||
| opacity: 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
Removed unused transition
ChristophWurst
approved these changes
May 3, 2021
|
/backport to stable3 |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
enh/AppSidebar-event
branch
from
8225e17
to
a157547
Compare
|
Fix eslint |
|
@skjnldsv Wanna use this PR to also submit the event for closing the title edit (#1288 (comment))? |
Not really, I don't know the planned outcome nor usage of this one, so I figured I wanted to stay safe and not dive into too much as I'm already drowning 😅 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because sometimes we need to wait for the sidebar to really be opened, let's add proper events.
Will help fix viewer tests that waits for the Sidebar to finish open
Example (animation duration changed for this screencast)
