Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix datepicker overflow when week numbers are shown #1917

Merged
merged 1 commit into from
May 4, 2021
Merged

Fix datepicker overflow when week numbers are shown #1917

merged 1 commit into from
May 4, 2021

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented May 4, 2021 •
edited
Loading

This PR fixes the width of the datepicker when show-week-number is true.

weeknumber

Closes #1014.

@raimund-schluessler raimund-schluessler added bug Something isn't working feature: datepicker Related to the date/time picker component labels May 4, 2021
@raimund-schluessler
Add class to datepicker if showWeekNumber is true
d62a940 
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler force-pushed the fix/1014/datepicker-weeknumber branch from 7016d6d to d62a940 Compare May 4, 2021 12:31
@raimund-schluessler raimund-schluessler marked this pull request as ready for review May 4, 2021 12:32
@raimund-schluessler raimund-schluessler mentioned this pull request May 4, 2021
Closed
@raimund-schluessler raimund-schluessler changed the title Add class to datepicker if showWeekNumber is true Fix datepicker overflow when week numbers are shown May 4, 2021
@skjnldsv skjnldsv merged commit b8e063c into master May 4, 2021
@skjnldsv skjnldsv deleted the fix/1014/datepicker-weeknumber branch May 4, 2021 13:18
@skjnldsv skjnldsv added the 4. to release Ready to be released and/or waiting for tests to finish label May 4, 2021
@skjnldsv skjnldsv added this to the 4.0.0 milestone May 4, 2021
@skjnldsv
Copy link
Contributor

skjnldsv commented May 4, 2021

/backport to stable3

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 4, 2021
Closed
@raimund-schluessler
Copy link
Contributor Author

backport to stable3

Probably fails, because we didn't backport #1880 (which should actually also get a backport)

@skjnldsv
Copy link
Contributor

skjnldsv commented May 4, 2021

/backport to backport/1880/stable3

@skjnldsv
Copy link
Contributor

skjnldsv commented May 4, 2021

/backport to backport-1880-stable3

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 4, 2021
Merged
@skjnldsv skjnldsv mentioned this pull request Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@tcitworld tcitworld tcitworld approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feature: datepicker Related to the date/time picker component
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Datepicker to narrow when show-week-numbers
3 participants
@raimund-schluessler @skjnldsv @tcitworld