Fix first and last action input padding #1967
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the padding of the ActionInput in case it is the first or last entry. The currently set margin lead to a gap between the popover arrow and the input element.
Before:
After:
In case one switches from ActionButton to ActionInput like it happens in Calendar, this will still lead to a "jumping" of the popover menu, since the ActionButton has a different height than the ActionInput with the additional padding (see nextcloud/calendar#3016). But the gap is not there anymore.
On a side note: I would say the additional padding is not really necessary (or at least to high). But since this is supposed to be a bug fix PR, I didn't remove it, but instead made it work properly 😉. @jancborchardt maybe to check if this is really what it is supposed to look like.