Safely check the global appName and handle its inexistence #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
bug
ChristophWurst
requested review from
PVince81,
raimund-schluessler,
artonge and
skjnldsv
ChristophWurst
force-pushed
the
fix/app-name-global-save-checking
branch
2 times, most recently
from
64a2f4c
to
c59679e
Compare
PVince81
reviewed
Jun 11, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
skjnldsv
requested changes
Jun 11, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
skjnldsv
force-pushed
the
fix/app-name-global-save-checking
branch
from
fbf756f
to
5688b2a
Compare
skjnldsv
approved these changes
Jun 11, 2021
marcoambrosini
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variable is set -> default is used, developers can overwrite the prop value
Variable is not set -> prop become required
Right now you can't use the AppContent without the global variable, because the code that sets the default is always evaluated and will throw a ReferenceError before the developer can even specify their own value. Ref nextcloud/mail#5165 (comment).
Then we can avoid hacks like nextcloud/spreed@c662744
The code is untested because neither @GretaD nor I can build this library at the moment.