Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppContent mobile display #2048

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Jun 22, 2021

Initial somehow fallback to inline, For proper sizing and people using virtual scrollers, let's go back to traditional block
Also, because this is a high-level scoped selector, !important is not needed and will allow apps to override this if needed 🤷

Fixes contacts + circles

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews design Design, UX, interface and interaction design feature: app-content Related to the app-content component labels Jun 22, 2021
}
.app-content-details {
display: initial !important;
display: block;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, we need this because stupid server have some conflicting rules on .app-content-list + .app-content-details

@GretaD GretaD merged commit 5be83be into master Jun 22, 2021
@GretaD GretaD deleted the fix/app-content-mobile-display branch June 22, 2021 07:53
@skjnldsv skjnldsv mentioned this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: app-content Related to the app-content component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants