Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type=button attribute to buttons #2069

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Jun 26, 2021

Closes #2068

Button elements which have explicit type attributes have been left unchanged.

@Pytal Pytal changed the title Add type attribute to buttons Add type=button attribute to buttons Jun 26, 2021
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the fix/button-prevent-submit branch from 4ee46d1 to da3d47a Compare June 26, 2021 03:22
@Pytal Pytal self-assigned this Jun 26, 2021
@Pytal Pytal added 3. to review Waiting for reviews bug Something isn't working labels Jun 26, 2021
@skjnldsv
Copy link
Contributor

/backport to stable3

@juliushaertl juliushaertl merged commit 4a757ff into master Jun 28, 2021
@juliushaertl juliushaertl deleted the fix/button-prevent-submit branch June 28, 2021 06:39
@skjnldsv skjnldsv mentioned this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of some components within a form causes undesired behaviour
3 participants