Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of status icons in Avatar component #2323

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

CarlSchwan
Copy link
Contributor

@CarlSchwan CarlSchwan commented Oct 18, 2021

Now use 40% with of parent a max size of 18px. For talk participant bar
the size remains unchanged still 18px, but for the new avatar component
in the navbar the size is now 13px.

Before:
image

After:
image

Fix nextcloud/server#29353

Signed-off-by: Carl Schwan carl@carlschwan.eu

Now use 40% with of parent a max size of 18px. For talk participant bar
the size remains unchanged still 18px, but for the new avatar component
in the navbar the size is now 13px.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Oct 18, 2021
@CarlSchwan CarlSchwan self-assigned this Oct 18, 2021
Copy link
Contributor

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could go even lower than that, like 30%, so that we have a proportion similar to what's in talk's participants bar

@CarlSchwan
Copy link
Contributor Author

I think we could go even lower than that, like 30%, so that we have a proportion similar to what's in talk's participants bar

image

30% is to small in my opinion

@CarlSchwan CarlSchwan merged commit 5c588fa into master Oct 21, 2021
@CarlSchwan CarlSchwan deleted the fix/status-icon-size branch October 21, 2021 09:20
@CarlSchwan CarlSchwan mentioned this pull request Nov 16, 2021
@nickvergessen
Copy link
Contributor

/backport to stable4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Plasma highdpi] Status icon on the top right too big on highdpi
4 participants