-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust breadcrumb appearance #2411
Conversation
a9b0676
to
a340491
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!! 🚀
a340491
to
5ea8616
Compare
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
5ea8616
to
12a07d3
Compare
Looks so much better! Only 2 tiny suggestions regarding colour:
What do you think? |
I don't mind. I just tried to resemble the text color currently used in the breadcrumbs, where we have three states: normal, hovered and focused.
The normal (not hovered, not focuses) uses opacity 0.5 with --color-main-text at the moment. Opacity 0.7 is for hover.
Hovered is opacity 0.7. Focused uses opacity 1. So if we use opacity 1 for hovering, we need another way to indicate focus, or make focus and hover look the same. What do you prefer? |
@nimishavijay I hope you don't mind that I merge this now, but it makes it a lot easier to implement the other improvements. I would propose that you do a follow-up PR with your design adjustments. I am fine with whatever @nextcloud/designers agree on. |
Yup, would be best if focus and hover look the same. :) And then as @nimishavijay described, not using opacity as modifier for the text color but And hey, looks very nice, thank you so much! :) |
Could we use the button component in the mid run? If we'd do that we'd get the outline focus from it only when navigating with the keyboard and no changes with the mouse. |
I would strongly advise against that.
I would propose to adjust the Breadcrumb instead to show the desired design. Should be a lot simpler than using |
First step to fix #2410.
The breadcrumb now uses
ChevronRight
as a separator and has a background as hover feedback.For a live example, please have a look at the docs:
https://deploy-preview-2411--nextcloud-vue-components.netlify.app/#/Components/Breadcrumbs?id=breadcrumbs-1
I had to rename the component class to
vue-crumb
since the server CSS kept interfering. If we want to usecrumb
instead, we will have to explicitly overwrite all interfering server rules.Still todo see #2410 (comment)