Add option to always show actions #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: marco <marcoambrosini@pm.me>
marcoambrosini
added
bug
marcoambrosini
requested review from
jancborchardt,
ChristophWurst,
julien-nc,
skjnldsv and
nimishavijay
skjnldsv
approved these changes
Dec 28, 2021
GretaD
approved these changes
Dec 28, 2021
GretaD
deleted the
feature/listItem/add-option-to-always-show-actions
branch
|
@marcoambrosini just for info – is this now a per-list-item setting? Cause it should always be applied to all ListItems in the AppContentList, right? |
|
It is on a per component basis, but in general you use only one component and loop over some data, so developers will likely have to add the prop only once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2340
Added new prop that allows developers to always show the actions to the right of details and counter. See second item in the list.
Screen.Recording.2021-12-27.at.17.01.56.mov
Signed-off-by: marco marcoambrosini@pm.me