Fix error spam from buttons #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 8, 2022
nickvergessen
commented
Mar 8, 2022
src/components/Button/Button.vue
Outdated
| @@ -361,7 +361,7 @@ export default { | |||
|
|
|||
| methods: { | |||
| getText() { | |||
| return this.$slots.default ? this.$slots.default[0].text.trim() : null | |||
| return this.$slots.default && this.$slots.default[0] && this.$slots.default[0].text ? this.$slots.default[0].text.trim() : null | |||
There was a problem hiding this comment.
Before:
Error in beforeUpdate hook: "TypeError: this.$slots.default[0].text is undefined"
found in
---> <Button>
TypeError: this.$slots.default[0].text is undefined
getText Button.js:1
beforeUpdate Button.js:1
VueJS 6
invokeWithErrorHandling
callHook
before
flushSchedulerQueue
nextTick
flushCallbacks
nickvergessen
commented
Mar 8, 2022
| */ | ||
| type: { | ||
| type: String, | ||
| validator(value) { | ||
| return ['primary', 'tertiary', 'error', 'warning', 'success', ''].indexOf(value) !== -1 | ||
| return ['primary', 'secondary', 'tertiary', 'error', 'warning', 'success', ''].indexOf(value) !== -1 |
There was a problem hiding this comment.
Before:
[Vue warn]: Invalid prop: custom validator check failed for prop "type".
found in
---> <Button> at src/components/Button/Button.vue
<LobbyStatus> at src/components/RightSidebar/LobbyStatus.vue
<AppSidebar> at src/components/AppSidebar/AppSidebar.vue
<RightSidebar> at src/components/RightSidebar/RightSidebar.vue
<Content> at src/components/Content/Content.vue
<App> at src/App.vue
<Root>
src/components/Button/Button.vue
Outdated
| @@ -361,7 +361,7 @@ export default { | |||
|
|
|||
| methods: { | |||
| getText() { | |||
| return this.$slots.default ? this.$slots.default[0].text.trim() : null | |||
| return this.$slots.default && this.$slots.default[0] && this.$slots.default[0].text ? this.$slots.default[0].text.trim() : null | |||
There was a problem hiding this comment.
Probably better this.$slots?.default[0]?.text?
There was a problem hiding this comment.
Regression #2547
There was a problem hiding this comment.
@nickvergessen @JuliaKirschenheuter
I think the correct expression would be:
this.$slots?.default?.[0]?.text?.trim()
There was a problem hiding this comment.
That sadly didn't work 🤷♂️
There was a problem hiding this comment.
Hmm. Okay, but did you noticed the ?. directly behind of default ? That wasn't included in the commit. Though it is needed when default can be null/undefined.
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/fix-error-spam-from-buttons
branch
from
d3e9dc8
to
b170766
Compare
raimund-schluessler
approved these changes
Mar 8, 2022
JuliaKirschenheuter
approved these changes
Mar 8, 2022
nickvergessen
added
4. to release
marcoambrosini
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.