Increase padding of ColorPicker #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary since Popover component got border-radius Signed-off-by: Quentin Guidée <quentin.guidee@gmail.com>
quentinguidee
added
3. to review
raimund-schluessler
approved these changes
Mar 24, 2022
raimund-schluessler
requested review from
jancborchardt,
nimishavijay,
skjnldsv and
marcoambrosini
nimishavijay
approved these changes
Jun 2, 2022
marcoambrosini
approved these changes
Jun 3, 2022
|
Looks great @quentinguidee! :) Also unrelated, but the button (here "Choose" needs more padding to left and right of the text, looks cut off currently. @marcoambrosini |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary since Popover component got border-radius. Otherwise it feels a bit tight