Keep text in InputConfirmCancel static
#2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
requested review from
skjnldsv,
jancborchardt,
nimishavijay,
marcoambrosini and
GretaD
raimund-schluessler
added
enhancement
skjnldsv
approved these changes
Jun 17, 2022
szaimen
approved these changes
Jun 20, 2022
marcoambrosini
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jancborchardt Since you mentioned this in the chat, this fixes the jumping text when switching to edit mode in
AppNavigationItem.Before:
After:
@nextcloud/designers Please note the tradeoff, that the left border of the input field is now closer to the icon than before. I am not sure this is wanted, but I think it's the only way to keep the text static without making it look weird when the input is not shown.