Fix vue material design icons HTML validation #2833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since v5.0.0 of the lib, the property decorative has been removed. This means the "decorative" is added to the span element, causing the HTML validation to fail: > Attribute decorative not allowed on element span at this point. Upstream commit robcresswell/vue-material-design-icons@c65d8ea > This patch also removes the default title, encouraging better > accessibility by removing unhelpful titles that dont indicate usage. The > `decorative` prop has been removed and any icons that do not have a > meaningful title will be hidden from screen readers. Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
bug
nickvergessen
requested review from
raimund-schluessler,
JuliaKirschenheuter and
marcoambrosini
CarlSchwan
approved these changes
Jul 13, 2022
mejo-
approved these changes
Jul 14, 2022
nickvergessen
deleted the
bugfix/noid/html-validation-vue-material-design-icons
branch
This was referenced Jul 15, 2022
Closed
|
/backport to stable5 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v5.0.0 of the lib, the property decorative has been removed.
This means the "decorative" is added to the span element, causing the
HTML validation to fail:
Upstream commit
robcresswell/vue-material-design-icons@c65d8ea
Signed-off-by: Joas Schilling coding@schilljs.com