Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add headline to sidebar sections to improve landmarks #2845

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Add headline to sidebar sections to improve landmarks #2845

merged 1 commit into from
Jul 18, 2022

Conversation

nickvergessen
Copy link
Contributor

Section lacks heading. Consider using h2-h6 elements to add identifying
headings to all sections, or else use a div element instead for any
cases where no heading is needed.

Signed-off-by: Joas Schilling coding@schilljs.com

@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Jul 15, 2022
@nickvergessen nickvergessen mentioned this pull request Jul 15, 2022
Open
JuliaKirschenheuter
JuliaKirschenheuter approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, since AppSidebar would have <h2> heading, we could use here <h3> as direct child. In this case it is also not possible to use role="heading" + aria-level -> and it is ok to use <h3> with class="hidden-visually"

@nickvergessen
Add headline to sidebar sections to improve landmarks
57bae6d 
> Section lacks heading. Consider using h2-h6 elements to add identifying
> headings to all sections, or else use a div element instead for any
> cases where no heading is needed.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/add-headline-to-sidebar-section branch from 1f15d43 to 57bae6d Compare July 18, 2022 12:27
@nickvergessen
Copy link
Contributor Author

Fixed code style

src/components/AppSidebarTab/AppSidebarTab.vue#L35

Expected 1 line break after opening tag (<h3>), but no line breaks found

@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 18, 2022
@nickvergessen nickvergessen merged commit b6e357d into master Jul 18, 2022
@nickvergessen nickvergessen deleted the bugfix/noid/add-headline-to-sidebar-section branch July 18, 2022 13:12
@nickvergessen nickvergessen mentioned this pull request Jul 20, 2022
Closed
5 tasks
@juliushaertl juliushaertl mentioned this pull request Aug 2, 2022
Closed
@nickvergessen
Copy link
Contributor Author

/backport to stable5

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@Pytal Pytal Pytal approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @JuliaKirschenheuter @Pytal