Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ListItem css & add compact mode #2856

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Fix ListItem css & add compact mode #2856

merged 2 commits into from
Jul 29, 2022

Conversation

jotoeri
Copy link
Contributor

@jotoeri jotoeri commented Jul 18, 2022

This fixes two things:

  • The ListItem was not really usable without subtitle but with counter. Different line heights and a completely messed up design were the result. This now brings that case onto one line, when only title and counter are available and fixes the ListItem height, so all ListItems are the same height.
Before After
Full odd looking gif
old non_compact
  • In connection to the fixed height, it introduces a compact-mode for the list item. Once used without subtitle or in a mixed case, the default sizes are quite large. Esp. if there are multiple elements without subtitle, but a few with subtitle, there is just too much space inbetween those items without. Thus the compact mode reduces the size of the ListItem a bit, so the mixed case looks good.
Default Compact Mode
non_compact compact_mode

@jotoeri jotoeri added the 2. developing Work in progress label Jul 18, 2022
@jotoeri jotoeri changed the title Fix ListItem Fix ListItem css Jul 18, 2022
@jotoeri jotoeri added the design Design, UX, interface and interaction design label Jul 18, 2022
@raimund-schluessler

This comment was marked as outdated.

@jotoeri

This comment was marked as outdated.

@jotoeri

This comment was marked as outdated.

@Chartman123

This comment was marked as outdated.

Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri jotoeri force-pushed the fix/list_item branch 2 times, most recently from a600145 to 8a85d38 Compare July 28, 2022 17:55
@jotoeri
Copy link
Contributor Author

jotoeri commented Jul 28, 2022

Just checked it on Talk and didn't see any problems. So should be good to go now. 🙂

}

&__actions {
flex: 0 0 auto;
align-self: center;
justify-content: center;

margin-left: 4px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After
actions_old actions_new2

@@ -565,15 +593,14 @@ export default {
&__subtitle {
overflow: hidden;
flex-grow: 1;
padding-right: 4px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shifted to counter margin, so it also applies if no subtitle used.

@jotoeri jotoeri requested a review from Chartman123 July 28, 2022 18:26
Copy link
Contributor

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jotoeri could you add a compact example in the docs too?

@jotoeri jotoeri added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 29, 2022
@jotoeri

This comment was marked as outdated.

@jotoeri jotoeri added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 29, 2022
@marcoambrosini

This comment was marked as outdated.

Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
Copy link
Contributor Author

jotoeri commented Jul 29, 2022

preview

@marcoambrosini marcoambrosini merged commit 982ee87 into master Jul 29, 2022
@marcoambrosini marcoambrosini deleted the fix/list_item branch July 29, 2022 12:49
@jotoeri jotoeri added bug Something isn't working enhancement New feature or request labels Aug 2, 2022
@jotoeri jotoeri changed the title Fix ListItem css Fix ListItem css & add compact mode Aug 2, 2022
@jotoeri
Copy link
Contributor Author

jotoeri commented Aug 2, 2022

/backport to stable5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants