Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make captions real headings for improved a11y #2865

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Make captions real headings for improved a11y #2865

merged 1 commit into from
Jul 20, 2022

Conversation

nickvergessen
Copy link
Contributor

@nickvergessen nickvergessen commented Jul 20, 2022 •
edited
Loading

@nickvergessen
Make captions real headings for improved a11y
d3e9ef2 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Jul 20, 2022
@nickvergessen nickvergessen added this to the 5.3.2 milestone Jul 20, 2022
@nickvergessen nickvergessen mentioned this pull request Jul 20, 2022
Closed
5 tasks
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 20, 2022
@Pytal Pytal merged commit 8ecb883 into master Jul 20, 2022
@Pytal Pytal deleted the bugfix/noid/make-captions-headings branch July 20, 2022 18:22
@juliushaertl juliushaertl modified the milestones: 5.3.2, 6.0.0 Aug 2, 2022
@juliushaertl juliushaertl mentioned this pull request Aug 2, 2022
Closed
@nickvergessen
Copy link
Contributor Author

/backport to stable5

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@Pytal Pytal Pytal approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: app-navigation Related to the app-navigation component
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Add proper h2 elements for accessibility
4 participants
@nickvergessen @raimund-schluessler @Pytal @juliushaertl